BUG-FIX: Remove duplicate try_site_packages() call in load_nvidia_dynamic_lib #1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_lib Remove redundant call to finder.try_site_packages() on line 28 that was immediately overwritten by the same call on line 30. This duplicate call was wasteful (unnecessary filesystem traversal) and indicates a code review oversight. The function now correctly calls try_site_packages() only once, improving performance with no functional changes. Location: cuda_pathfinder/cuda/pathfinder/_dynamic_libs/load_nvidia_dynamic_lib.py:28
Contributor
Collaborator
Author
|
/ok to test 437aa36 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes a duplicate call to try_site_packages() in the _load_lib_no_cache function, eliminating an unnecessary filesystem traversal that was immediately overwritten.
Key Changes:
- Removed redundant
try_site_packages()call that was overwritten by an identical call on the next line
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
leofang
added
bug
kkraus14
approved these changes
Nov 18, 2025
|
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG-FIX: Remove duplicate try_site_packages() call in load_nvidia_dynamic_lib
Remove redundant call to
try_site_packages()that was immediately overwritten by the same call on the next line. This duplicate call was wasteful (unnecessary filesystem traversal).